Global Styles: Don't filter out typography variations where the heading and body fonts are the same #61327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -45 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
scruffian
force-pushed
the
update/global-styles-typography
branch
from
21b862d to
d9c547d
Compare
Update packages/edit-site/src/components/global-styles/style-variations-container.js Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> Update packages/edit-site/src/components/global-styles/style-variations-container.js Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> update function name remove variations which are empty once the property has been filtered out move to a reduce function remove duplicate values Global Styles: Don't filter out variations where the heading and body fonts are the sane
scruffian
force-pushed
the
update/global-styles-typography
branch
from
d9c547d to
e13b192
Compare
|
Flaky tests detected in f8ce6a6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9191548100
|
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…61327) Update packages/edit-site/src/components/global-styles/style-variations-container.js Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> Update packages/edit-site/src/components/global-styles/style-variations-container.js Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> update function name remove variations which are empty once the property has been filtered out move to a reduce function remove duplicate values Global Styles: Don't filter out variations where the heading and body fonts are the sane Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…61327) Update packages/edit-site/src/components/global-styles/style-variations-container.js Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> Update packages/edit-site/src/components/global-styles/style-variations-container.js Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> update function name remove variations which are empty once the property has been filtered out move to a reduce function remove duplicate values Global Styles: Don't filter out variations where the heading and body fonts are the sane Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When we show typography variations in Global Styles > Typography we remove variations where the heading and body fonts are the same.
Why?
This was done originally because we were showing the names of the heading and body font families. We no longer do this so I don't think it makes sense to remove variations where the body and heading fonts are the same, as these could still be interesting variations.
How?
Removes the code that filters out heading and body font families and replaces it with the same checks we use for color variations - this just filters out variations which have no styles and settings keys.
Testing Instructions
Screenshots or screencast